-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-67230: document new csv quoting modes in whatsnew (gh-103491) #103491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add blurb about changes to :mod:`csv`.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
This interface is horrible. I see a change was rewuested by @merwok but can't see what it is. So... I have made the requested changes; please review again. |
Thanks for making the requested changes! @merwok: please review the changes made to this pull request. |
Ah! «requested changes» is a review status (others are «approved» and «commented») |
@smontanaro looks good! I tried to do this myself last night, but I was at my kid's soccer practice and discovered that the official iPhone GitHub app does not have all the functionality of the web GUI. 😢 |
@smontanaro <https://github.com/smontanaro> looks good! I tried to do
this myself last night, but I was at my kid's soccer practice and
discovered that the official iPhone GitHub app does not have all the
functionality of the web GUI. 😢
Funny thing. I discovered the same thing about the Android app.
… Message ID: ***@***.***>
|
@smontanaro were you responsible for the csv.QUOTE_NULL? You're an absolute legend! |
Not exactly. Someone else suggested it years ago. I tend to catch most proposed changes to the csv module... |
Add blurb about recent change to csv.